(ci) mark flakey test suites as "continue-on-error: true" #2874
Conversation
…n complete a release pipeline and get signed binaries with release
ramin
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2874 +/- ##
==========================================
- Coverage 51.85% 50.32% -1.53%
==========================================
Files 167 167
Lines 10801 10801
==========================================
- Hits 5601 5436 -165
- Misses 4708 4880 +172
+ Partials 492 485 -7 |
|
@MSevey have a look at the changes i had to add to version_bump here, seems it hadn't run in a looooooooong time but was failing once i was skipping flakey tests, copied what we have in celestia-app |
@ramin there is currently a bug in app's version bumping that I'm digging into. Will circle back once I've fixed app to know if there are changes to reapply here. |
|
@ramin I would add this update to the version_bump job https://github.com/celestiaorg/celestia-app/pull/2773/files This ensures proper handling of any non master/main release branches. |
|
@MSevey ok this is up to date |
in the interest of having a full pipeline for release 0.12.0, have marked the swamp and unit w/ race tests to
continue-on-error: trueso though the job will still fail in ci, the pipeline and dependent steps after those tests (namely version_bump + goreleaser) will still proceed as though they were successful, and we can get signed binaries with the tagged release